aniva/Pantograph
aniva/Pantograph
1
1
Fork 0
Code Issues 18 Pull requests 4 Projects Releases Packages Wiki Activity

fix: Capture nested tactic failure #135

Merged
aniva merged 6 commits from bug/nested-tactic-failure into dev 2024-12-07 18:51:26 -08:00
Conversation 1 Commits 6 Files changed 7 +65 -36
aniva commented 2024-12-05 21:42:41 -08:00
Owner
Copy link
  • fix: Capture nested tactic failure. e.g. If the simp in exact ⟨0, by simp⟩ fails, the whole tactic should fail.
  • fix: Export GoalState.tryTactic
  • refactor: Remove all fileNames in favour of getFileName
  • chore: Cleanup some test infrastructure
- fix: Capture nested tactic failure. e.g. If the `simp` in `exact ⟨0, by simp⟩` fails, the whole tactic should fail. - fix: Export `GoalState.tryTactic` - refactor: Remove all `fileName`s in favour of `getFileName` - chore: Cleanup some test infrastructure
aniva added this to the v0.2.22 milestone 2024-12-05 21:42:41 -08:00
aniva self-assigned this 2024-12-05 21:42:41 -08:00
aniva commented 2024-12-06 00:00:03 -08:00
Author
Owner
Copy link

Should be good to go. Pending feedback from original author.

Should be good to go. Pending feedback from original author.
aniva deleted branch bug/nested-tactic-failure 2024-12-07 18:51:27 -08:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
category
bug
Bugs, Test failures, Build failures

  
category
chore
Code cleanup

  
category
doc
Documentation

  
category
feature
New features and enhancements

  
category
optimization
Performance improvements

  
category
organization
Versioning and structure

  
part/Delation

Kernel to search view

  
part/Elab

Parsing and elaboration

  
part/Environment

Environments, Library, Catalog

  
part/FFI

Library and FFI

  
part/Frontend

Driving the Lean compiler

  
part/Goal

Goal evolution, proof terms, tactics

  
part/REPL

For text based interaction

  
part/Serial

Serialization, IO

  
priority
high

  
priority
irrelevant
Issues that will not be fixed or are intended features

  
priority
low
For things that don't impede release schedule

  
priority
medium

  
priority
pending-measurement
For nebulous problems

No labels
category
bug
category
chore
category
doc
category
feature
category
optimization
category
organization
part/Delation
part/Elab
part/Environment
part/FFI
part/Frontend
part/Goal
part/REPL
part/Serial
priority
high
priority
irrelevant
priority
low
priority
medium
priority
pending-measurement
Milestone
Clear milestone
No items
No milestone
v0.2.22
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
aniva
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: aniva/Pantograph#135
No description provided.
Delete branch "bug/nested-tactic-failure"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?