aniva/Pantograph
aniva/Pantograph
1
1
Fork 0
Code Issues 18 Pull requests 4 Projects Releases Packages Wiki Activity

feat(goal): Subsumption #287

Open
aniva wants to merge 20 commits from goal/subsume into dev
pull from: goal/subsume
merge into: aniva:dev
Conversation 3 Commits 20 Files changed 7 +377 -8
aniva commented 2025-08-20 20:44:21 -07:00
Owner
Copy link

Given a goal goal, and a list of solved goals mvarIds, determine if one of the goals in mvarIds subsumes goal. This is only a semi-solver, i.e. it will miss some cases when subsumption is possible.

  • Subsumption by completed goals
  • Detect cycle of parent goals
  • Cross-branch subsumption
  • Return subsumptor (the goal providing the solution or cue) relative to the subsumend (the goal being subsumed)
  • REPL Bindings
  • Do not subsume if a target is not of type Prop.
  • Preferentially subsume rather than cycle
Given a goal `goal`, and a list of solved goals `mvarIds`, determine if one of the goals in `mvarIds` subsumes `goal`. This is only a semi-solver, i.e. it will miss some cases when subsumption is possible. - [X] Subsumption by completed goals - [X] Detect cycle of parent goals - [X] Cross-branch subsumption - [X] Return subsumptor (the goal providing the solution or cue) relative to the subsumend (the goal being subsumed) - [X] REPL Bindings - [x] Do not subsume if a target is not of type `Prop`. - [x] Preferentially subsume rather than cycle
aniva self-assigned this 2025-08-20 20:44:22 -07:00
aniva added this to the v0.3.8 milestone 2025-08-21 13:07:18 -07:00
aniva commented 2025-08-23 21:19:19 -07:00
Author
Owner
Copy link

How does this thing interact with have? It's worth investigating!

How does this thing interact with `have`? It's worth investigating!
aniva commented 2025-08-24 21:03:45 -07:00
Author
Owner
Copy link

Subsumption on one state is largely useless. We need subsumption on two states.

Subsumption on one state is largely useless. We need subsumption on two states.
aniva commented 2025-08-25 05:52:20 -07:00
Author
Owner
Copy link

Another question is how does this interact with unfold? Since we are testing for isDefEq, it may render unfold tactics impossible.

Another question is how does this interact with `unfold`? Since we are testing for `isDefEq`, it may render unfold tactics impossible.
This was caused by insufficient collection of dependencies. Moreover,
branch unification should filter out assigned goals.
This was caused by insufficient collection of dependencies. Moreover,
branch unification should filter out assigned goals.
This pull request can be merged automatically.
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin goal/subsume:goal/subsume
git switch goal/subsume
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
category
bug
Bugs, Test failures, Build failures

  
category
chore
Code cleanup

  
category
doc
Documentation

  
category
feature
New features and enhancements

  
category
optimization
Performance improvements

  
category
organization
Versioning and structure

  
part/Delation

Kernel to search view

  
part/Elab

Parsing and elaboration

  
part/Environment

Environments, Library, Catalog

  
part/FFI

Library and FFI

  
part/Frontend

Driving the Lean compiler

  
part/Goal

Goal evolution, proof terms, tactics

  
part/REPL

For text based interaction

  
part/Serial

Serialization, IO

  
priority
high

  
priority
irrelevant
Issues that will not be fixed or are intended features

  
priority
low
For things that don't impede release schedule

  
priority
medium

  
priority
pending-measurement
For nebulous problems

No labels
category
bug
category
chore
category
doc
category
feature
category
optimization
category
organization
part/Delation
part/Elab
part/Environment
part/FFI
part/Frontend
part/Goal
part/REPL
part/Serial
priority
high
priority
irrelevant
priority
low
priority
medium
priority
pending-measurement
Milestone
Clear milestone
No items
No milestone
v0.3.8
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
aniva
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: aniva/Pantograph#287
No description provided.
Delete branch "goal/subsume"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?